[FFmpeg-devel] [PATCH 4/5] ppc: lavc: use LOCAL_ALIGNED instead of DECLARE_ALIGNED
jamrial at gmail.com
Sun Mar 15 02:29:44 CET 2015
On 14/03/15 10:05 PM, Michael Niedermayer wrote:
> On Sat, Mar 14, 2015 at 08:35:29PM -0300, James Almer wrote:
>> On 14/03/15 3:18 PM, Michael Niedermayer wrote:
>>> On Sat, Mar 14, 2015 at 03:30:27PM +0000, Christophe Gisquet wrote:
>>>> The later may yield incorrect code for on-stack variables.
>>>> libavcodec/ppc/h264dsp.c | 10 ++++-----
>>>> libavcodec/ppc/h264qpel.c | 50 ++++++++++++++++++++---------------------
>>>> libavcodec/ppc/vp8dsp_altivec.c | 2 +-
>>>> 3 files changed, 31 insertions(+), 31 deletions(-)
>> This apparently broke compilation for ppc.
>> /home/fate/fate/slots/powerpc-linux-gnu-gcc-4.3.5/src/libavcodec/ppc/h264dsp.c:270: error: invalid parameter combination for AltiVec intrinsic
> argh, i tested this, but i had altivec disabled it seems
>> It should use LOCAL_ALIGNED_16() rather than LOCAL_ALIGNED(16,...), which shows that
>> whatever these LOCAL_ALIGNED_# macros do is needed, and the fifth patch in this set
>> is not correct.
> LOCAL_ALIGNED_# does not work either, ill revert the patch
Ah, I see. I assumed it would since those macros are exclusively for x86 and ppc, thus
explaining why they exist in the first place.
I retract my comment about the fifth patch then.
More information about the ffmpeg-devel