[FFmpeg-devel] [PATCH] avfilter/showwaves: add single_pic option

[Clément Bœsch]

On Mon, Mar 16, 2015 at 04:11:24PM +0100, Stefano Sabatini wrote:
> On date Sunday 2014-12-28 12:48:19 +0100, Clément Bœsch encoded:
> > On Fri, Dec 26, 2014 at 01:16:07AM +0100, Stefano Sabatini wrote:
> > > On date Friday 2014-12-26 00:17:53 +0100, Clément Bœsch encoded:
> [...]
> > The first case has its use cases. Random example:
> > https://soundcloud.com/explore
> > 
> > > 
> > > The two approaches are not mutually exclusive, but the latter is
> > > probably more flexible.
> > > 
> > 
> > In the second case, you'll probably need successive scaling before you
> > reach the targeted size. It's probably a bit more complex than the current
> > patch, but might do the trick.
> > 
> > Note that, while I don't think it will matter, the beginning of the track
> > will probably suffer from accuracy given how many time it will be
> > averaged/scaled.
> > 
> 
> > > I'll prepare a patch to cover case 2. About case 1, I wonder if having
> > > a dedicated filter (sharing part of the code of showwaves) wouldn't be
> > > a better approach, but I'm not sure it will.
> > 
> > I'm a bit lazy to do that, feel free to take over this patch.
> 
> What do you think of a separate filter to cover single_pic? See
> attached patch.
> -- 
> FFmpeg = Fiendish and Frenzy Monstrous Puritan Extravagant Guru

> From 5ecb0190806d39bdd869de951634000b1d1e1c0f Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Cl=C3=A9ment=20B=C5=93sch?= <u at pkh.me>
> Date: Wed, 24 Dec 2014 15:03:26 +0100
> Subject: [PATCH] lavfi: add showwavespic filter
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> This is a variant of showaves. It is implemented as a different filter so
> that the user is not allowed to use meaningless options which belong to
> showaves (such as rate).
> 
> Major edits done by Stefano Sabatini, from a patch by ubitux.
> 
> See thread:
> From: Clément Bœsch <u at pkh.me>
> To: ffmpeg-devel at ffmpeg.org
> Date: Wed, 24 Dec 2014 15:03:26 +0100
> Subject: [FFmpeg-devel] [PATCH] avfilter/showwaves: add single_pic option
> 
> TODO: bump minor
> ---
>  doc/filters.texi            |  27 +++++
>  libavfilter/Makefile        |   1 +
>  libavfilter/allfilters.c    |   1 +
>  libavfilter/avf_showwaves.c | 274 ++++++++++++++++++++++++++++++++++++++------
>  4 files changed, 268 insertions(+), 35 deletions(-)
> 

Good idea, patch LGTM after a quick look, but since it's based on my code
I haven't much comment.

BTW, it might be relevant to add a fate test.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150317/fd14b63d/attachment.asc>