[FFmpeg-devel] [PATCH] avcodec/nvenc: Add support for H.265 encoding
philipl at overt.org
Wed Mar 25 05:38:30 CET 2015
On Tue, 24 Mar 2015 09:54:13 +0100
Timo Rothenpieler <timo at rothenpieler.org> wrote:
> Yes, I did exactly that in my implementation:
> The code i wrote there is completely untested(Except that h264 still
> works), because i don't have any compatible hardware, so the one you
> tested is clearly the one that should be prefered.
> Dropping SDK <5 support is fine with me, as long as it's not
> backported to 2.6. The primary gain from supporting the old SDK is
> that it works with much older nvidia driver versions.
> I'll submit the patch that drops the old API support, so you can
> rebase your patch on top of it.
> Looks good to merge otherwise.
I've taken your logic to check the SM version - I had been
wondering how old hardware should be detected and excluded.
I've also noticed that the profile handling code is completely broken -
you can't set a profile using -profile:v - it appears we're handling
this in an incorrect way - but I'm not sure what correct is. libx264
has its own profile option which appears to be necessary but then I
don't understand what sets avctx->profile.
Anyway, that's a separate problem we can solve independently of h.265.
More information about the ffmpeg-devel