[FFmpeg-devel] [PATCH 1/4] libavdevice/avfoundation: add framerate and video size options

[Michael Niedermayer]

On Sun, Mar 29, 2015 at 12:27:54AM +0100, Thilo Borgmann wrote:
> Am 27.03.15 um 14:34 schrieb Matthieu Bouron:
> > On Sat, Mar 21, 2015 at 4:51 PM, Thilo Borgmann <thilo.borgmann at mail.de>
> > wrote:
> > [...]
> >> +        [video_device setValue:selected_format forKey:@"activeFormat"];
> >> +        [video_device setValue:min_frame_duration
> >> forKey:@"activeVideoMinFrameDuration"];
> >> +        [video_device setValue:min_frame_duration
> >> forKey:@"activeVideoMaxFrameDuration"];
> >>                                 ^^^
> >> Should be max_frame_duration in the third line.
> >> IIRC there is functionality in the API to check if setting
> >> min/max_frame_duration is available for the device, isn't it? Please
> >> check, in
> >> case there it is not, there is an alternative way to set the framerate
> >> (IIRC).
> >>
> > 
> > It is purely intentionnal to use the min_frame_duration for the
> > activeVideoMaxFrameDuration to acheive a better consistant framerate.
> > There is no way to check if the range is accepted by the device but as
> > stated by the documentation, applied range values that does not come from
> > ranges returned by the API will throw an exception.
> > There is an alternative way to set the framerate using
> > AVCaptureConnection.setVideo(Min|Max)FrameDuration but it has been
> > deprecated in iOS 7 and I do not intend to support it.
> 
> I misunderstood your these lines.
> 
> Patch ok, please apply.

applied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

He who knows, does not speak. He who speaks, does not know. -- Lao Tsu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150329/307ec2f7/attachment.asc>