[FFmpeg-devel] [PATCH 4/4] lavf/matroskaenc: don't try to end the segment when the output isn't seekable

Michael Niedermayer michaelni at gmx.at
Sun Mar 29 23:11:40 CEST 2015


On Sun, Mar 29, 2015 at 11:08:51PM +0200, Michael Niedermayer wrote:
> On Sun, Mar 29, 2015 at 02:56:00PM -0600, Rodger Combs wrote:
> > I can see the reasoning here, but as "small enough" here means 32K,
> 
> my concern was that some app might use a single large buffer without
> seek function.
> 32k is too small i agree
> 
> 
> > I don't think this would be worth doing on a per-muxer basis.
> 
> > Maybe if we had a more general way to tell the muxer about segment boundaries,
> 
> That can be done by adding a field to AVFormatContext or
> AVFormatInternal
> 
> 

> > or if segment.c provided a single AVIOContext, with a write() function that passes through to a sub-context and a seek() function that reopened (and seeked within) previous segments if necessary? (Though we'd need an option to disable seeks into previous files to avoid inter-process read/write races).
> 
> that sounds like the ideal solution if developer time is no factor

one additional disadvantage of this though would be that if the
header does get updated at the end this would mismatch if only a
subset of segments get concatenated

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you think the mosad wants you dead since a long time then you are either
wrong or dead since a long time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150329/c2210af7/attachment.asc>


More information about the ffmpeg-devel mailing list