[FFmpeg-devel] [libav-devel] [PATCH] aacsbr: break infinite loop in sbr_hf_calc_npatches

Andreas Cadhalpun andreas.cadhalpun at googlemail.com
Tue May 5 21:16:44 CEST 2015

On 23.04.2015 17:50, Claudio Freire wrote:
> On Thu, Apr 23, 2015 at 12:43 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> ok, so is the patch the correct solution or are the fields already
>> invalid before this loop and should have been checked prior ?
> I think either the fields are already invalid before the loop (which
> could mean an invalid file), or there is a slight bug on the loop, the
> patch just avoids infinite loop in those cases.
> What I'm yet unable to decide is whether it's the first or the second
> case (invalid input file vs bugged loop). I'll have to carefully
> review the specs for that, and sadly I only have drafts.

Did you get any further with this?

If not, I think it would be good to apply the patch I sent.
The code can always be changed later if a better solution is found.

Best regards,

More information about the ffmpeg-devel mailing list