[FFmpeg-devel] [libav-devel] [PATCH] aacsbr: break infinite loop in sbr_hf_calc_npatches

Michael Niedermayer michaelni at gmx.at
Thu May 7 17:56:44 CEST 2015

On Tue, May 05, 2015 at 09:16:44PM +0200, Andreas Cadhalpun wrote:
> On 23.04.2015 17:50, Claudio Freire wrote:
> > On Thu, Apr 23, 2015 at 12:43 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> ok, so is the patch the correct solution or are the fields already
> >> invalid before this loop and should have been checked prior ?
> > 
> > I think either the fields are already invalid before the loop (which
> > could mean an invalid file), or there is a slight bug on the loop, the
> > patch just avoids infinite loop in those cases.
> > 
> > What I'm yet unable to decide is whether it's the first or the second
> > case (invalid input file vs bugged loop). I'll have to carefully
> > review the specs for that, and sadly I only have drafts.
> Did you get any further with this?
> If not, I think it would be good to apply the patch I sent.
> The code can always be changed later if a better solution is found.



Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150507/c90c1897/attachment.asc>

More information about the ffmpeg-devel mailing list