[FFmpeg-devel] [PATCHv3 2/2] mpegtsenc: Implement writing of Opus trim_start/trim_end control values

Carl Eugen Hoyos cehoyos at ag.or.at
Mon Nov 2 16:12:10 CET 2015


Sebastian Dröge <slomo <at> coaxion.net> writes:

> +            if (ts_st->opus_pending_trim_start)
> +              ctrl_header_size += 2;
> +            if (trim_end)
> +              ctrl_header_size += 2;

You could move the additions inside the larger if 
blocks below, that would make the code slightly 
cleaner imo, feel free to ignore.

Could you clarify that the specification was fixed?
I believe it wasn't some time ago or am I wrong?

Carl Eugen


More information about the ffmpeg-devel mailing list