[FFmpeg-devel] [PATCH] avfilter: add anoisesrc

[Paul B Mahol]

On 11/4/15, Kyle Swanson <k at ylo.ph> wrote:
> Hi,
>
> On Wed, Nov 4, 2015 at 12:30 PM, Nicolas George <george at nsup.org> wrote:
>> Thanks for the updated patch, see comments below.
>>
>> Le quartidi 14 brumaire, an CCXXIV, Kyle Swanson a ecrit :
>>> Signed-off-by: Kyle Swanson <k at ylo.ph>
>>> ---
>>>  Changelog                    |   1 +
>>>  doc/filters.texi             |  36 +++++++
>>>  libavfilter/Makefile         |   1 +
>>>  libavfilter/allfilters.c     |   1 +
>>>  libavfilter/asrc_anoisesrc.c | 222
>>> +++++++++++++++++++++++++++++++++++++++++++
>>>  libavfilter/version.h        |   4 +-
>>>  6 files changed, 263 insertions(+), 2 deletions(-)
>>>  create mode 100644 libavfilter/asrc_anoisesrc.c

[...]

>>>
>>> +AVFILTER_DEFINE_CLASS(anoisesrc);
>>> +
>>> +static av_cold int query_formats(AVFilterContext *ctx)
>>> +{
>>> +    ANoiseSrcContext *s = ctx->priv;
>>> +    static const int64_t chlayouts[] = { AV_CH_LAYOUT_MONO, -1 };
>>> +    int sample_rates[] = { s->sample_rate, -1 };
>>
>>> +    static const enum AVSampleFormat sample_fmts[] = {
>>> +        AV_SAMPLE_FMT_DBL,
>>> +        AV_SAMPLE_FMT_NONE
>>> +    };
>>
>> I already commented on that: please avoid floating-point computations
>> unless
>> they are absolutely necessary.
>>
>
> I can change this, but most filters I've seen have used floating point
> sample formats. Anyone else have any opinions on this?
>

Using double precision for audio noise source sounds like overkill.
So using S16 is fine. Anyway you could add support for both if you really
want.