[FFmpeg-devel] [PATCH] swresample/options: change rematrix_maxval default to 1.0

[Ganesh Ajjanagadde]

On Thu, Nov 5, 2015 at 9:14 PM, Michael Niedermayer
<michael at niedermayer.cc> wrote:
> On Wed, Nov 04, 2015 at 10:40:45PM -0500, Ganesh Ajjanagadde wrote:
>> This changes the default to not clip, and thus matches libavresample as
>> well.
>>
>> Documentation has been accordingly updated (with some typo fixes).
>>
>> API users have complained about this, see e.g
>> https://github.com/mpv-player/mpv/commit/bf69edb1c2bac2ac11343d8e086f0540a0e4b5df.
>>
>> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
>> ---
>>  doc/resampler.texi      | 5 +++--
>>  libswresample/options.c | 2 +-
>>  2 files changed, 4 insertions(+), 3 deletions(-)
>
> iam with whatever default people prefer

I personally agree with wm4 here on the fact that the current default
is not good, but that is subjective.

A more serious point for me is that this is a complaint API users have
made. I think we should cater to our users and match Libav in such
things which are trivial. We already bend over backwards to have
options for compatibility with avconv, see e.g the silly "cutoff" vs
"resample_cutoff". Why not bend over and maintain compatibility with
them for defaults? It can help clients like mpv avoid such silly
ifdefry. Maybe too late for this particular instance, but I see no
harm.

Will leave open for comments for some time, otherwise I take your
comment as a general ack and will push this weekend.

>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Many that live deserve death. And some that die deserve life. Can you give
> it to them? Then do not be too eager to deal out death in judgement. For
> even the very wise cannot see all ends. -- Gandalf
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>