[FFmpeg-devel] [PATCH] configure: don't let check_inline_asm override explicitly-disabled options

Michael Niedermayer michael at niedermayer.cc
Tue Nov 10 17:25:59 CET 2015


On Tue, Nov 10, 2015 at 08:54:11AM -0600, Rodger Combs wrote:
> ---
>  configure | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/configure b/configure
> index f770534..6063281 100755
> --- a/configure
> +++ b/configure
> @@ -900,8 +900,7 @@ check_inline_asm(){
>      name="$1"
>      code="$2"
>      shift 2
> -    disable $name
> -    check_cc "$@" <<EOF && enable $name
> +    disabled $name || { disable $name && check_cc "$@" <<EOF && enable $name; }
>  void foo(void){ __asm__ volatile($code); }
>  EOF
>  }

check_inline_asm should return false for the disabled case as the
checked code is not available

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151110/dafd1398/attachment.sig>


More information about the ffmpeg-devel mailing list