[FFmpeg-devel] [PATCH] avfilter/af_dynaudnorm: remove pow2

Ganesh Ajjanagadde gajjanag at mit.edu
Fri Nov 27 20:39:04 CET 2015


On Fri, Nov 27, 2015 at 2:24 PM, Paul B Mahol <onemda at gmail.com> wrote:
> On 11/27/15, Ganesh Ajjanagadde <gajjanagadde at gmail.com> wrote:
>> On Wed, Nov 25, 2015 at 10:36 AM, Ronald S. Bultje <rsbultje at gmail.com>
>> wrote:
>>> Hi,
>>>
>>> On Wed, Nov 25, 2015 at 8:00 AM, Ganesh Ajjanagadde
>>> <gajjanagadde at gmail.com>
>>> wrote:
>>>>
>>>> pow2 is being used for trivial squaring. Its name is not good: is this
>>>> 2^x or x^2?
>>>
>>>
>>> 2^x is exp2, not pow2. (I have no opinion on the patch itself.)
>>>
>>> Ronald
>>
>> @Paul: is this patch fine?
>
> You could add macro SQR.

I don't like macro for such things; in such a case I find pow2
superior. Patch dropped then.


More information about the ffmpeg-devel mailing list