[FFmpeg-devel] [PATCH 1/4] avutil/tablegen: add tablegen libm compatibility shims

Ganesh Ajjanagadde gajjanag at mit.edu
Sat Nov 28 20:51:25 CET 2015


On Sat, Nov 28, 2015 at 2:45 PM, Derek Buitenhuis
<derek.buitenhuis at gmail.com> wrote:
> On 11/28/2015 7:33 PM, Ganesh Ajjanagadde wrote:
>> 2. Clement's idea AFAIK does not work, since the names must be
>> identical to the standard C names for the build to work with/without
>> hardcoded tables.
>
> ... yes it can. It doesn't work without more work, but it it sure can
> work.

In principle of course, e.g with more ifdefry, configure, or something
of that sort. I do not believe this is what he meant.
In any case, the point is moot - the implementations are not broken -
if they are, avutil/libm needs fixing as well.

>
> Anyway, shouldn't this patce dropped, since 79abf2d0ded860acf505de22c4f7a750e5e98446
> removed hardcoded tables anyway?

No, if you actually read even the first line of the commit message,
you can see it was only for aac, not for this patch series.

>
> - Derek
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


More information about the ffmpeg-devel mailing list