[FFmpeg-devel] [PATCH] blockdsp: remove high bit depth parameter

Ronald S. Bultje rsbultje at gmail.com
Thu Oct 1 14:40:46 CEST 2015


Hi,

On Thu, Oct 1, 2015 at 8:28 AM, Christophe Gisquet <
christophe.gisquet at gmail.com> wrote:

> 2015-09-28 18:51 GMT+02:00 Christophe Gisquet <
> christophe.gisquet at gmail.com>:
> > I admit I haven't run this over all of fate, so it would be nice to
> > validate nothing actually uses it for pixels (I have see nothing of
> > the sort).
>
> Passes fate-video fate-vcodec on Win64.


Hm, let's see:

bash-3.2$ grep ff_pixblockdsp_init ../libavcodec/*
../libavcodec/asvenc.c:    ff_pixblockdsp_init(&a->pdsp, avctx);
../libavcodec/avdct.c:        ff_pixblockdsp_init(&pdsp, avctx);
../libavcodec/dnxhdenc.c:    ff_pixblockdsp_init(&ctx->m.pdsp, avctx);
../libavcodec/dvenc.c:    ff_pixblockdsp_init(&pdsp, avctx);
../libavcodec/mpegvideo_enc.c:    ff_pixblockdsp_init(&s->pdsp, avctx);

bash-3.2$ grep AV_PIX_FMT ../libavcodec/dvenc.c ../libavcodec/dnxhdenc.c
../libavcodec/mpegvideo_enc.c ../libavcodec/asvenc.c
../libavcodec/dnxhdenc.c:    case AV_PIX_FMT_YUV422P10:
../libavcodec/dnxhdenc.c:        AV_PIX_FMT_YUV422P10,

bash-3.2$ grep clear_block ../libavcodec/dnxhdenc.c
            ctx->bdsp.clear_block(ctx->blocks[4]);
            ctx->bdsp.clear_block(ctx->blocks[5]);
            ctx->bdsp.clear_block(ctx->blocks[6]);
            ctx->bdsp.clear_block(ctx->blocks[7]);

So this may break 10bit dnxhd encoding.

Ronald


More information about the ffmpeg-devel mailing list