[FFmpeg-devel] [PATCH] ffserver_config: check for INT_MIN before doing FFABS

Ganesh Ajjanagadde gajjanagadde at gmail.com
Fri Oct 9 17:31:22 CEST 2015


FFABS(INT_MIN) is not safe. Alternative of using FFNABS is not as
readable.

Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
---
 ffserver_config.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ffserver_config.c b/ffserver_config.c
index 691ff7b..9fc1f00 100644
--- a/ffserver_config.c
+++ b/ffserver_config.c
@@ -460,7 +460,7 @@ static int ffserver_set_int_param(int *dest, const char *value, int factor,
     if (tmp < min || tmp > max)
         goto error;
     if (factor) {
-        if (FFABS(tmp) > INT_MAX / FFABS(factor))
+        if (tmp == INT_MIN || FFABS(tmp) > INT_MAX / FFABS(factor))
             goto error;
         tmp *= factor;
     }
-- 
2.6.1



More information about the ffmpeg-devel mailing list