[FFmpeg-devel] [PATCH] avcodec: remove leftover iff_byterun1 decoder

Ronald S. Bultje rsbultje at gmail.com
Mon Oct 12 00:56:33 CEST 2015


Hi,

On Sun, Oct 11, 2015 at 6:26 PM, Andreas Cadhalpun <
andreas.cadhalpun at googlemail.com> wrote:

> On 11.10.2015 23:56, Ronald S. Bultje wrote:
> > On Sun, Oct 11, 2015 at 5:50 PM, Andreas Cadhalpun <
> > andreas.cadhalpun at googlemail.com> wrote:
> >> On 11.10.2015 23:39, Ronald S. Bultje wrote:
> >>> On Sun, Oct 11, 2015 at 5:17 PM, Andreas Cadhalpun <
> >>> andreas.cadhalpun at googlemail.com> wrote:
> >>>> --- a/libavcodec/avcodec.h
> >>>> +++ b/libavcodec/avcodec.h
> >>>> @@ -241,7 +241,7 @@ enum AVCodecID {
> >>>>      AV_CODEC_ID_ANM,
> >>>>      AV_CODEC_ID_BINKVIDEO,
> >>>>      AV_CODEC_ID_IFF_ILBM,
> >>>> -    AV_CODEC_ID_IFF_BYTERUN1,
> >>>> +#define AV_CODEC_ID_IFF_BYTERUN1 AV_CODEC_ID_IFF_ILBM
> >>>>      AV_CODEC_ID_KGV1,
> >>>>      AV_CODEC_ID_YOP,
> >>>>      AV_CODEC_ID_VP8,
> >>>>
> >>>
> >>> Should this go under a version define so it disappears in 3 years?
> >>
> >> It shouldn't as long as Libav still uses this codec ID.
> >>
> >
> > Hm, ... ok so it's one of these political bits. OK, fine, I'll drop that
> > objection. Rest of patch is OK.
>
> Thanks, pushed.
>
> > AV_CODEC_ID_H265 on the other hand could disappear in such a way.
> >
> >
> > That's unrelated to this patch though, so no need to hold this one up for
> > that :)
>
> Yes, I just mentioned it in case you want to write a patch for it. :)


Oh, I see, you're volunteering me... Hm... Nobody likes making changes to
core headers, I suppose?

Ronald


More information about the ffmpeg-devel mailing list