[FFmpeg-devel] [PATCH] avfilter, swresample, swscale: use fabs, fabsf instead of FFABS

Ganesh Ajjanagadde gajjanag at mit.edu
Tue Oct 13 06:26:32 CEST 2015


On Tue, Oct 13, 2015 at 12:16 AM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> Ganesh Ajjanagadde <gajjanag <at> mit.edu> writes:
>
>> Bench from libavfilter/astats on a 15 min clip.
>
> I believe that your test would indicate that the
> old variant is faster or that no result can be
> given which is what my tests show.

Look at the bench and the numbers again, I have provided it above.
They are essentially identical in the best case (most number of runs),
the new variant is faster in the worst case. You have not provided a
bench proving otherwise.

>
> I am not sure if it makes sense to apply a patch
> that is meant to improve speed if this improvement
> can't be shown.

I believe I have shown it above clearly.

>
> Carl Eugen
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


More information about the ffmpeg-devel mailing list