[FFmpeg-devel] [PATCH 2/3] simple_idct12: align C and x86

Michael Niedermayer michael at niedermayer.cc
Wed Oct 14 13:39:22 CEST 2015


On Wed, Oct 14, 2015 at 08:46:22AM +0200, Christophe Gisquet wrote:
[...]

> > also IIUC this is just to make C and x86 match, so it could just be
> > skiped with no ill effects except that tnen x86 and C would not be
> > bitexact matches ?
> 
> Yes, and the 12bpp.jpg fate should not be added then, because it'd
> test just the C idct.

testing just the C idct is still better than testing none

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151014/b2ef54b9/attachment.sig>


More information about the ffmpeg-devel mailing list