[FFmpeg-devel] [PATCH] libavformat/riff.c: Adding support of PCM_S24LE in WAVEFORMATEXTENSIBLE

Hendrik Leppkes h.leppkes at gmail.com
Thu Oct 22 23:08:35 CEST 2015


On Thu, Oct 22, 2015 at 9:19 PM, Thierry Foucu <tfoucu at gmail.com> wrote:
> ---
>  libavformat/riff.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/libavformat/riff.c b/libavformat/riff.c
> index a9197e7..7de8936 100644
> --- a/libavformat/riff.c
> +++ b/libavformat/riff.c
> @@ -487,5 +487,6 @@ const AVCodecGuid ff_codec_wav_guids[] = {
>      { AV_CODEC_ID_ATRAC3P,  { 0xBF, 0xAA, 0x23, 0xE9, 0x58, 0xCB, 0x71, 0x44, 0xA1, 0x19, 0xFF, 0xFA, 0x01, 0xE4, 0xCE, 0x62 } },
>      { AV_CODEC_ID_EAC3,     { 0xAF, 0x87, 0xFB, 0xA7, 0x02, 0x2D, 0xFB, 0x42, 0xA4, 0xD4, 0x05, 0xCD, 0x93, 0x84, 0x3B, 0xDD } },
>      { AV_CODEC_ID_MP2,      { 0x2B, 0x80, 0x6D, 0xE0, 0x46, 0xDB, 0xCF, 0x11, 0xB4, 0xD1, 0x00, 0x80, 0x5F, 0x6C, 0xBB, 0xEA } },
> +    { AV_CODEC_ID_PCM_S24LE,{ 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x10, 0x00, 0x80, 0x00, 0x00, 0xAA } },
>      { AV_CODEC_ID_NONE }
>  };
> --

This is the generic PCM GUID, isn't it? It could be any PCM bitdepth,
so the patch does not appear correct to me.

- Hendrik


More information about the ffmpeg-devel mailing list