[FFmpeg-devel] [PATCH] version.sh: add note that ffversion.h is auto-generated

Ronald S. Bultje rsbultje at gmail.com
Sun Oct 25 02:27:51 CET 2015


Hi,

On Sat, Oct 24, 2015 at 9:13 PM, Ganesh Ajjanagadde <gajjanagadde at gmail.com>
wrote:

> On Sat, Oct 24, 2015 at 9:05 AM, Ganesh Ajjanagadde
> <gajjanagadde at gmail.com> wrote:
> > On Thu, Oct 15, 2015 at 7:04 PM, Ganesh Ajjanagadde
> > <gajjanagadde at gmail.com> wrote:
> >> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
> >> ---
> >>  version.sh | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/version.sh b/version.sh
> >> index f9754eb..a9d7e39 100755
> >> --- a/version.sh
> >> +++ b/version.sh
> >> @@ -54,6 +54,7 @@ GUARD=$(echo "$2" | sed 's/\//_/' | sed 's/\./_/' |
> tr '[:lower:]' '[:upper:]' |
> >>  # Update version header only on revision changes to avoid spurious
> rebuilds
> >>  if test "$NEW_REVISION" != "$OLD_REVISION"; then
> >>      cat << EOF > "$2"
> >> +/* Automatically generated by version.sh, do not manually edit! */
> >>  #ifndef $GUARD
> >>  #define $GUARD
> >>  $NEW_REVISION
> >> --
> >> 2.6.1
> >>
> >
> > ping
>
> Just noticed that officially, I am free to push this (see point 12
> under development policy): per the MAINTAINERS file, no one is
> maintaining this, the 3 days window has passed, and I think it is ok.


Patch is OK.

Ronald


More information about the ffmpeg-devel mailing list