[FFmpeg-devel] [PATCH] avutil/wchar_filename: add av_warn_unused_result

Ganesh Ajjanagadde gajjanag at mit.edu
Fri Oct 30 18:49:20 CET 2015


On Fri, Oct 30, 2015 at 12:57 PM, Ganesh Ajjanagadde <gajjanag at mit.edu> wrote:
> On Fri, Oct 30, 2015 at 6:07 AM, Michael Niedermayer
> <michael at niedermayer.cc> wrote:
>> On Thu, Oct 15, 2015 at 08:01:56PM -0400, Ganesh Ajjanagadde wrote:
>>> Current code is fine, this just adds robustness.
>>>
>>> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
>>> ---
>>>  libavutil/wchar_filename.h | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/libavutil/wchar_filename.h b/libavutil/wchar_filename.h
>>> index c553c46..2ade321 100644
>>> --- a/libavutil/wchar_filename.h
>>> +++ b/libavutil/wchar_filename.h
>>> @@ -23,6 +23,7 @@
>>>  #include <windows.h>
>>>  #include "mem.h"
>>>
>>> +av_warn_unused_result
>>>  static inline int utf8towchar(const char *filename_utf8, wchar_t **filename_w)
>>>  {
>>>      int num_chars;
>>
>> LGTM
>>
>> thanks
>
> thanks, will push later. Please consider all other
> av_warn_unused_result patches dropped; I am going to add in a much
> more targeted fashion first. Please don't waste time reviewing them.

pushed
>
>>
>> [...]
>> --
>> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>>
>> Asymptotically faster algorithms should always be preferred if you have
>> asymptotical amounts of data
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org
>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>


More information about the ffmpeg-devel mailing list