[FFmpeg-devel] [PATCH] configure: make assignment of variable to '=' explicit

Ganesh Ajjanagadde gajjanagadde at gmail.com
Sun Sep 13 08:26:04 CEST 2015


op== is confusing, as it may easily be mistook for an equality check,
while in reality it is doing an assigment to '='.
This patch has the additional benefit of cleaning up 2 warnings from shellcheck.net.

Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
---
 configure | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index da18e70..2fb625b 100755
--- a/configure
+++ b/configure
@@ -622,12 +622,12 @@ enable_deep_weak(){
 }
 
 enabled(){
-    test "${1#!}" = "$1" && op== || op=!=
+    test "${1#!}" = "$1" && op='=' || op=!=
     eval test "x\$${1#!}" $op "xyes"
 }
 
 disabled(){
-    test "${1#!}" = "$1" && op== || op=!=
+    test "${1#!}" = "$1" && op='=' || op=!=
     eval test "x\$${1#!}" $op "xno"
 }
 
-- 
2.5.1



More information about the ffmpeg-devel mailing list