[FFmpeg-devel] [PATCH] avcodec: Switch bitrate to 64bit with the bump

[Michael Niedermayer]

On Sun, Sep 13, 2015 at 11:19:00PM +0200, Carl Eugen Hoyos wrote:
> On Sunday 13 September 2015 12:30:20 am Michael Niedermayer wrote:
> > On Sat, Sep 12, 2015 at 07:52:42PM +0200, Carl Eugen Hoyos wrote:
> > > Hi!
> > >
> > > Attached is a new patch that should be ready to be applied 
> > > no matter if we drop compatibility or not.
> > >
> > > Please comment (quickly if possible), Carl Eugen
> >
> > i think there are a few changes missing:
> 
> New patch attached.

the entries in avcodec_options are wrong

{"b", "set bitrate (in bits/s)", OFFSET(bit_rate), AV_OPT_TYPE_INT, {.i64 = AV_CODEC_DEFAULT_BITRATE }, 0, INT_MAX, A|V|E},
{"ab", "set bitrate (in bits/s)", OFFSET(bit_rate), AV_OPT_TYPE_INT, {.i64 = 128*1000 }, 0, INT_MAX, A|E},

bit_rate is not a AV_OPT_TYPE_INT its a AV_OPT_TYPE_INT64 after this

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150914/1ed31772/attachment.sig>