[FFmpeg-devel] [PATCH] Revert "matroskaenc: refuse to write AAC without valid extradata"

wm4 nfxjfg at googlemail.com
Mon Sep 21 12:14:27 CEST 2015

On Mon, 21 Sep 2015 11:57:11 +0200
"Vittorio Gambaletta (VittGam)" <ffmpeg-dev at vittgam.net> wrote:

> Il 21.09.2015 07:39:24 Ronald S. Bultje ha scritto:
> > Is this still necessary if you use the adtstoaasc bitstream filter?
> Yes.
> Il 21.09.2015 09:45:55 Hendrik Leppkes ha scritto:
> > Simply reverting and thus allowing broken files to be created once
> > again is not a good idea. I recommend to properly fix the problem and
> > not just revert.
> The fact is that reverting seems to produce valid files anyway.
> If I feed the "broken" output file to ffmpeg -i, the audio samplerate is
> correctly shown, and there's no other warning about this issue.
> Maybe it's just the input file that's broken (it is, since it also has
> borked h264 timestamps...), but then ffmpeg is able to produce valid
> Matroska files anyway.

No, just because FFmpeg eats it, it's not a valid file. FFmpeg contains
a shitload of hacks to workaround broken files (and some are really
needed, because there's LOTS of multimedia software generaring broken
files). But FFmpeg should at least attempt to not write broken or
problematic files, because we are not evil and want our files to work

More information about the ffmpeg-devel mailing list