[FFmpeg-devel] [PATCH] Revert "matroskaenc: refuse to write AAC without valid extradata"

[Hendrik Leppkes]

On Mon, Sep 21, 2015 at 11:57 AM, Vittorio Gambaletta (VittGam)
<ffmpeg-dev at vittgam.net> wrote:
> Il 21.09.2015 07:39:24 Ronald S. Bultje ha scritto:
>>
>> Is this still necessary if you use the adtstoaasc bitstream filter?
>
>
> Yes.
>
> Il 21.09.2015 09:45:55 Hendrik Leppkes ha scritto:
>>
>> Simply reverting and thus allowing broken files to be created once
>> again is not a good idea. I recommend to properly fix the problem and
>> not just revert.
>
>
> The fact is that reverting seems to produce valid files anyway.
>
> If I feed the "broken" output file to ffmpeg -i, the audio samplerate is
> correctly shown, and there's no other warning about this issue.
>
> Maybe it's just the input file that's broken (it is, since it also has
> borked h264 timestamps...), but then ffmpeg is able to produce valid
> Matroska files anyway.
>

AAC without extradata is invalid, there is no discussion about that.
As wm4 says, just because ffmpeg accepts it anyway doesn't really change that.