[FFmpeg-devel] [PATCH 1/4] lavu/opt: switch AV_OPT flags to shift-based formatting
Rodger Combs
rodger.combs at gmail.com
Mon Sep 21 19:42:56 CEST 2015
> On Sep 21, 2015, at 05:49, Nicolas George <george at nsup.org> wrote:
>
> Le jour de la Récompense, an CCXXIII, Rodger Combs a écrit :
>> ---
>> libavutil/opt.h | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> What is the benefit? I am a bit afraid it would make the merging work
> harder.
>
> Regards,
>
> --
> Nicolas George
I find that the shift-based style makes it more clear that we're defining a bitmask, and slightly easier to be sure to set the value for a new item correctly. It's not a huge deal either way, though, and I'm not really attached to it.
More information about the ffmpeg-devel
mailing list