[FFmpeg-devel] [PATCH] hevc: fix WPP mode

Christophe Gisquet christophe.gisquet at gmail.com
Wed Sep 23 17:53:12 CEST 2015


Hi,

2015-09-23 17:06 GMT+02:00 Mickaƫl Raulet <mraulet at insa-rennes.fr>:
> the fix looks weird to me. There is something else underlying.

The issue appeared in d249e682 (not the hash I reported, for some
reason). If you want to test, that commit is buggy (it causes
crashes): commit 7117547 is needed to fix it.

IIRC (the patch is rather old...), when this happens,
s->sao_pixel_buffer* seems to have old data. This looked consistent
with the thread for the following line accessing this buffer before it
had been filled by the threading running on the line, and thus the
patch.

If I'm mistaken, do you see anything else that could cause the issue?
Maybe I'm indeed missing something in the implementation of d249e682.

-- 
Christophe


More information about the ffmpeg-devel mailing list