[FFmpeg-devel] [PATCH] avformat/movenc: suppress -Wstrict-overflow warnings

Ganesh Ajjanagadde gajjanagadde at gmail.com
Fri Sep 25 19:59:31 CEST 2015


On Fri, Sep 18, 2015 at 5:15 PM, Ganesh Ajjanagadde
<gajjanagadde at gmail.com> wrote:
> This patch results in identical behavior of movenc, and suppresses -Wstrict-overflow
> warnings observed in GCC 5.2.
> I have manually checked that all usages are safe, and overflow possibility does
> not exist with this expression rewrite.
>
> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
> ---
>  libavformat/movenc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> index af03d1e..6e4a1a6 100644
> --- a/libavformat/movenc.c
> +++ b/libavformat/movenc.c
> @@ -854,7 +854,7 @@ static int get_cluster_duration(MOVTrack *track, int cluster_idx)
>  {
>      int64_t next_dts;
>
> -    if (cluster_idx >= track->entry)
> +    if (cluster_idx - track->entry >= 0)
>          return 0;
>
>      if (cluster_idx + 1 == track->entry)
> --
> 2.5.2
>

ping


More information about the ffmpeg-devel mailing list