[FFmpeg-devel] [PATCHv2 1/2] ffplay: add support for interactive volume control

[Ganesh Ajjanagadde]

On Sun, Sep 27, 2015 at 12:16 PM, Clément Bœsch <u at pkh.me> wrote:
> On Sun, Sep 27, 2015 at 11:57:41AM -0400, Ganesh Ajjanagadde wrote:
>> On Sun, Sep 27, 2015 at 11:40 AM, Clément Bœsch <u at pkh.me> wrote:
>> > On Sun, Sep 27, 2015 at 10:12:52AM -0400, Ganesh Ajjanagadde wrote:
>> > [...]
>> >> Yes, I consider the current usage terrible unless I am missing
>> >> something. volume filter is static, so once set, I can't adjust the
>> >> volume until I reinsert a new volume filter, etc. I can't simply
>> >> adjust the volume like I can with vlc/mpv with a simple keybinding.
>> >>
>> >
>> > There is a process_command() mechanism too if you want to change settings
>> > on the fly
>>
>> Hmm... that seems to be a libavfilter thing. We could consider adding
>> that to the volume filter.
>
> volume filter already supports it (see avfilter_process_command() and
> process_command callback in the filter code)

That "support" is IMHO not usable for interactive purposes in ffplay.
Typing "volume" everytime volume needs to be changed is IMHO not as
usable as the approach of this patch (in addition to the -af/-vf
whatever which by itself for me is bad compared to mpv/cvlc).
Furthermore, as I argued, this patch is correct.

>
> [...]
>
> --
> Clément B.
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>