[FFmpeg-devel] [PATCH v2 2/8] configure: Add version check for libkvazaar

Hendrik Leppkes h.leppkes at gmail.com
Tue Sep 29 21:42:23 CEST 2015


On Tue, Sep 29, 2015 at 9:39 PM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> Clément Bœsch <u <at> pkh.me> writes:
>
>> > +             { check_cpp_condition kvazaar.h "KVZ_API_VERSION >= 7" ||
>> > +               die "ERROR: kvazaar API version must be at least 7."; }
>>
>> Can you do something like require_pkg_config "kvazaar >= 1.2.3" instead?
>
> Please don't!
> This only adds an unneeded requirement (and a regression)
> to the library

It already requires pkg-config, all Clement is asking to also use it
to check the version, which makes a lot of sense.
Its also much more visible for users. API versions aren't meaningful
to users, while actual library versions are.


More information about the ffmpeg-devel mailing list