[FFmpeg-devel] [PATCH] avcodec/apedec: fix bug introduced in commit d3e5fbb1406995e07fccbff3ca8c1e24f57a1f7b

Ganesh Ajjanagadde gajjanag at mit.edu
Wed Sep 30 03:25:52 CEST 2015


On Tue, Sep 29, 2015 at 9:08 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Tue, Sep 29, 2015 at 07:27:03PM -0400, Ganesh Ajjanagadde wrote:
>> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
>> ---
>>  libavcodec/apedec.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> breaks fate
>
> --- ./tests/ref/fate/lossless-monkeysaudio-399  2015-09-29 13:42:22.893972599 +0200
> +++ tests/data/fate/lossless-monkeysaudio-399   2015-09-30 03:06:06.950988548 +0200
> @@ -1 +1 @@
> -a28d4e5f2192057f7d4bece870f40bd0
> +df8663c29d7cd7268d6ae77edd742bb5
> Test lossless-monkeysaudio-399 failed. Look at tests/data/fate/lossless-monkeysaudio-399.err for details.
> make: *** [fate-lossless-monkeysaudio-399] Error 1

Weird, unfortunately for whatever reason my fate does not test this
(though apedec gets compiled) so I can't reproduce. One suggestion I
have is removing the U at the end, that will prevent any unforeseen
signed/unsigned business which I thought was ok. Please change the
author tag if you do this.

>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Concerning the gods, I have no means of knowing whether they exist or not
> or of what sort they may be, because of the obscurity of the subject, and
> the brevity of human life -- Protagoras
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>


More information about the ffmpeg-devel mailing list