[FFmpeg-devel] [PATCH] ffplay: fix silence insertion on error or pause

Michael Niedermayer michael at niedermayer.cc
Mon Apr 4 12:23:05 CEST 2016

On Sun, Apr 03, 2016 at 09:37:58PM +0200, Marton Balint wrote:
> Insertion of silence was a bit broken since
> df34b700981de606ca4847e1ed0bfdf9ac3e9104 because the info whether or not the
> source buffer supposed to be silence must be kept between callbacks. Failing to
> do so causes rogue samples from the last buffer to be presented, I guess even a
> crash can occur under some circumstances.
> This patch uses a NULL audio_buf to keep the silence state across audio
> callbacks.
> Signed-off-by: Marton Balint <cus at passwd.hu>
> ---
>  ffplay.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

slightly off topic but
does it sound better to repeat the last packet or to fill in
silence for damaged packets ?

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160404/1660441f/attachment.sig>

More information about the ffmpeg-devel mailing list