[FFmpeg-devel] [Patch]Qualification task for TrueHD encoder

[Michael Niedermayer]

On Tue, Apr 05, 2016 at 10:45:18PM +0200, Michael Niedermayer wrote:
> Hi Disha
> 
> On Tue, Apr 05, 2016 at 06:50:33AM +0530, Disha Singh wrote:
> > This patch has an lpc issue, and needs some work with passing of parameters
> > in ff_lpc_calc_coeff(), which my mentor said he would help with.
> [...]
> 
> > +static ChannelParams   restart_channel_params[MAX_CHANNELS];
> > +static DecodingParams  restart_decoding_params[MAX_SUBSTREAMS];
> > +static BestOffset      restart_best_offset[NUM_CODEBOOKS] = {{0}};
> 
> "non const" statics are not allowed as they break with muliple
> encoder instances

that is if they would change, if they do not change they should be
const

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160405/ce4af911/attachment.sig>