[FFmpeg-devel] [PATCH 1/2] avformat/framehash: don't share write_header code with framecrc muxers

[Michael Niedermayer]

On Tue, Apr 12, 2016 at 07:32:44PM -0300, James Almer wrote:
> The uncodedframecrc muxer didn't like the new ff_framehash_write_header signature.
> This may also simplify further improvements to the output of framehash.
> 
> Signed-off-by: James Almer <jamrial at gmail.com>
> ---
>  libavformat/Makefile                    |  8 ++++----
>  libavformat/{framehash.c => framecrc.c} | 19 ++-----------------
>  libavformat/framecrcenc.c               |  2 +-
>  libavformat/hashenc.c                   | 27 +++++++++++++++++++++++++--
>  libavformat/internal.h                  |  2 +-
>  libavformat/uncodedframecrcenc.c        |  2 +-
>  6 files changed, 34 insertions(+), 26 deletions(-)
>  rename libavformat/{framehash.c => framecrc.c} (54%)

Iam not sure the version code is usefull, what is its usecase ?
(if it has no use maybe it could just be removed and make your life
 easier ?)

If you want to keep the version 1vs2 code maybe all the hash muxers
could use teh same context, this would also possibly allow more
future code sharing

either way, IMO the latest version should be default (its compatible
just has more fields)
we never would want to use a old version for checking
anything as it simply checks less at no advantage
also its IMO important that the extra fields are enabled for the
actual fate tests, this patchset would (please corect me if iam wrong)
remove this support from the actually used (in fate) framecrc

and for regression testing a fast checksum should be used, fate doesnt
need or benefit from a crypto hash like md5 or sha256, it just makes
it slower.
a crap hash like adler32 actually makes interpreting hash differences
possible as off by 1 differences result in small differences in the
adler32 checksum while a sha256 differecnce would not allow seperating
a off by one input difference from a totally different input


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are best at talking, realize last or never when they are wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160413/c60f5e7a/attachment.sig>