[FFmpeg-devel] [PATCH] fate: Add test for ticket 1833 (Ogg/Vorbis Chapters)

James Almer jamrial at gmail.com
Fri Apr 15 03:42:31 CEST 2016


On 4/14/2016 10:18 PM, Michael Niedermayer wrote:
> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
>  tests/fate-run.sh                   |    4 ++++
>  tests/fate/vorbis.mak               |    7 ++++++-
>  tests/ref/fate/vorbis-1833-chapters |   36 +++++++++++++++++++++++++++++++++++
>  3 files changed, 46 insertions(+), 1 deletion(-)
>  create mode 100644 tests/ref/fate/vorbis-1833-chapters
> 
> diff --git a/tests/fate-run.sh b/tests/fate-run.sh
> index 68b552c..3d58080 100755
> --- a/tests/fate-run.sh
> +++ b/tests/fate-run.sh
> @@ -96,6 +96,10 @@ probeframes(){
>      run ffprobe${PROGSUF} -show_frames -v 0 "$@"
>  }
>  
> +probechapters(){
> +    run ffprobe${PROGSUF} -show_chapters -v 0 "$@"
> +}
> +
>  probegaplessinfo(){
>      filename="$1"
>      shift
> diff --git a/tests/fate/vorbis.mak b/tests/fate/vorbis.mak
> index 4b72373..e31d1e8 100644
> --- a/tests/fate/vorbis.mak
> +++ b/tests/fate/vorbis.mak
> @@ -80,6 +80,11 @@ FATE_VORBIS += fate-vorbis-20
>  fate-vorbis-20: CMD = pcm -i $(TARGET_SAMPLES)/vorbis/6.ogg
>  fate-vorbis-20: REF = $(SAMPLES)/vorbis/6.pcm
>  
> +FATE_VORBIS_FFPROBE += fate-vorbis-1833-chapters

Missing ogg demuxer dependency.

Should be good aside from that.

> +fate-vorbis-1833-chapters: CMD = probechapters $(TARGET_SAMPLES)/vorbis/vorbis_chapter_extension_demo.ogg
> +
> +FATE_SAMPLES_FFPROBE += $(FATE_VORBIS_FFPROBE)
> +
>  FATE_SAMPLES_AVCONV-$(call DEMDEC, OGG, VORBIS) += $(FATE_VORBIS)
> -fate-vorbis: $(FATE_VORBIS)
> +fate-vorbis: $(FATE_VORBIS) $(FATE_VORBIS_FFPROBE)
>  $(FATE_VORBIS): CMP = oneoff
> diff --git a/tests/ref/fate/vorbis-1833-chapters b/tests/ref/fate/vorbis-1833-chapters
> new file mode 100644
> index 0000000..46bd77a
> --- /dev/null
> +++ b/tests/ref/fate/vorbis-1833-chapters
> @@ -0,0 +1,36 @@
> +[CHAPTER]
> +id=1
> +time_base=1/1000
> +start=0
> +start_time=0.000000
> +end=5000
> +end_time=5.000000
> +TAG:title=start
> +[/CHAPTER]
> +[CHAPTER]
> +id=2
> +time_base=1/1000
> +start=5000
> +start_time=5.000000
> +end=10500
> +end_time=10.500000
> +TAG:title=Five Seconds
> +[/CHAPTER]
> +[CHAPTER]
> +id=3
> +time_base=1/1000
> +start=10500
> +start_time=10.500000
> +end=15000
> +end_time=15.000000
> +TAG:title=Ten point 5 seconds
> +[/CHAPTER]
> +[CHAPTER]
> +id=4
> +time_base=1/1000
> +start=15000
> +start_time=15.000000
> +end=19849
> +end_time=19.849000
> +TAG:title=15 sec - over soon
> +[/CHAPTER]
> 



More information about the ffmpeg-devel mailing list