[FFmpeg-devel] [PATCH] lavf/matroskadec: Demux the PixelCrop* values

wm4 nfxjfg at googlemail.com
Fri Apr 15 13:06:48 CEST 2016

On Wed, 6 Apr 2016 17:09:21 -0600
Nic Wolfe <nic at wolfeden.ca> wrote:

> Thanks for elaborating wm4. Out of curiosity when you say "generic"
> and "normal" metadata what do you mean? Are you talking about using
> generic key names or is there another way to store metadata?
> I have attached a patch which adds a new AVPacketSideDataType and uses
> that type to store crop values in the AVStream's side data if they're
> found during Matroska demuxing. I have included a comment in avcodec.h
> with some of the info Dave shared above but I'm not sure if that is
> sufficient to call this "well defined".
> I'm aware that this is a complex topic and this patch is certainly not
> comprehensive but hopefully it is a step in the right direction.

I think this is much better. The problem are still the semantics. I
tried to discuss it in Libav, but nothing conclusive has emerged.

Maybe you could send this patch to libav-devel for discussion? (I feel
a bit sorry for playing this ping pong with a first time contributor.
If anyone has a better idea how to continue this, please make a

By the way, it's not a good idea to send base64 encoded patches. I
don't think most mail clients can expand them automatically. It
makes review harder. Just attach them normally. Also, try to avoid

More information about the ffmpeg-devel mailing list