[FFmpeg-devel] [PATCH]lavc/pgssubdec: Fix palette colourspace

[Carl Eugen Hoyos]

wm4 <nfxjfg <at> googlemail.com> writes:

> > > > Attached patch fixes ticket #4637 for me.  
> > 
> > > This looks like an entirely random change with no explanation 
> > > or justification given.  
> > 
> > I don't understand:
> > We have a sample that looks broken with current FFmpeg and fine 
> > with the patch applied - what other explanation do you need?
> 
> That would mean all PGS subtitles have been broken before, 
> and nobody noticed.

Don't you agree that for most samples, the difference 
is difficult (or actually impossible) to see?

> What proves that the sample you have renders correctly now?

Nothing.

You think that it is more likely that the sample was 
intentionally made to fool the vlc developers than to 
help them?

Carl Eugen