[FFmpeg-devel] [PATCH] pgssubdec: fix subpicture output colorspace and range
Carl Eugen Hoyos
cehoyos at ag.or.at
Sat Apr 23 18:18:03 CEST 2016
Jan Ekstrom <jeebjp <at> gmail.com> writes:
> >> + int hdtv;
> > Please rename to sdtv so you can remove the assignment
> > from init_decoder().
> What would that make of the default value?
The default value for (all) context variables is 0.
I am just trying to make the patch smaller, the
assignment looks a little ugly and with the logic
you suggested (I have no strong opinion) it is
> The current design lets me test for C true/false
This will still be possible (and makes sense).
> since the default is overridden at init() to -1
> and the HD content would have 1 set. I seem to
> remember that in stack various values are set to
> zero, but is the context always on stack?
The context variable is on the heat and it is guaranteed
to be set to 0 on initialization.
> > ctx->sdtv = h <=576 (or add braces).
> OK, will set the value according to the response to my
> previous question.
Thank you, Carl Eugen
More information about the ffmpeg-devel