[FFmpeg-devel] [PATCH] lavf/concatdec: remove unrelated change during codecpar merge.
derek.buitenhuis at gmail.com
Sun Apr 24 17:34:27 CEST 2016
On 4/24/2016 4:26 PM, Nicolas George wrote:
> That may be true, but the fix is incorrect, and should not have sneaked
> during a completely unrelated merge. For the sake of tracking changes, I
> want to revert this, and then look for a more correct fix.
The fix was deemed OK at the time by a few others, but by no means am I
claiming it was correct. I'll go with your word on it, since you know
the code best here.
> I will look at this example.
> (Note that I am not accusing you of dishonesty; I know the merges are
> a tremendous work, especially the evil plans, and I guess keeping track of
> the extra changes necessary to get everything working is hard.)
Didn't think you were, and thanks.
That particular merge (codecpar) was a team effort, though. All the commits
and issues were tracked on a github fork and branch, which still exists.
I do not plan to remove that branch, in case of regressions like this, in
which it can provide insight sometimes.
More information about the ffmpeg-devel