[FFmpeg-devel] [PATCH] lavf/concatdec: remove unrelated change during codecpar merge.
andrey_utkin at fastmail.com
Sun Apr 24 22:07:18 CEST 2016
On Sun, Apr 24, 2016 at 05:26:33PM +0200, Nicolas George wrote:
> Le sextidi 6 floréal, an CCXXIV, Derek Buitenhuis a écrit :
> > Removing this causes failures when concatdec is used to concat two H.264
> > streams from an MP4 source, when remuxed, IIRC.
> > Example: https://trac.ffmpeg.org/raw-attachment/ticket/3108/examplefiles.zip
> > ./ffmpeg -f concat -i tickets/3108/concatfile.txt -codec copy out.mp4
> That may be true, but the fix is incorrect, and should not have sneaked
> during a completely unrelated merge. For the sake of tracking changes, I
> want to revert this, and then look for a more correct fix.
> I will look at this example.
> (Note that I am not accusing you of dishonesty; I know the merges are
> a tremendous work, especially the evil plans, and I guess keeping track of
> the extra changes necessary to get everything working is hard.)
Please look at my email in ffmpeg-devel
'[PATCH] concatdec: Fix handling of H.264 in MP4 in case of "-auto_convert 0"'
it adds a check which allows to correctly handle both cases.
The chunk which Nicolas proposes to drop makes good work for default
(auto_convert=1) case and I wouldn't say that it shouldn't be there,
that code just doesn't consider auto_convert=0 case.
More information about the ffmpeg-devel