[FFmpeg-devel] [PATCH 2/2] avformat/mpegts: Skip over broken 0x80 headers

Michael Niedermayer michael at niedermayer.cc
Sat Apr 30 22:14:48 CEST 2016

On Sat, Apr 30, 2016 at 10:12:11AM -0400, Ronald S. Bultje wrote:
> Hi,
> On Sat, Apr 30, 2016 at 9:02 AM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> > > cane please revert this patch?
> > > I don't think there's wide support for it.
> >

> > Two developers seem to wait for an explanation why it should be reverted.

i think this comment is not helping to resolve things, its possibly
also not accurate, i wasnt waiting on anything in case iam the 2nd
devel, i just worked on other things and did not read this thread
for a day or 2

> Last time I checked, commits were not free-for-all, but should be done only
> after main concerns have been addressed.
> I've raised a main concern, and several developers have expressed support
> for the concern.

> The patch should not have been committed.

The patch was posted to the mailing list and noone objected to it
or asked to wait, it was commited 2 weeks after being posted.

> Please revert it.

I would like to see the oppinion of the people who maintain
the mpeg ts demuxer before its reverted.
MAINTAINERs lists Marton for mpegts.c
in practice i did try to maintain the code a bit over the last few
years as well, mostly because noone else did it ...

Maintaince burden was mentioned in this thread. I think the oppinion
of the people maintaining the code thus is important

If people want my oppinion, iam not sure if these 3 lines of code
would cause more burden than the potential of redebuging and re-fixing
this issue if a 2nd such file is found.
I think if the fix is removed it should at least be replaced by a
av_log warning so no time is wasted in debuging this again

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160430/d34cb6e8/attachment.sig>

More information about the ffmpeg-devel mailing list