[FFmpeg-devel] [PATCH 1/2] aacenc: add a faster version of twoloop as the "fast" coder

[Moritz Barsnick]

On Sun, Aug 07, 2016 at 00:51:29 +0100, Rostislav Pehlivanov wrote:
> +    //XXX: some heuristic to determine initial quantizers will reduce search time

Is the "XXX" trying to tell someone something?

> +        for (g = 0;  g < sce->ics.num_swb; g++) {

I detect a spurious space in there. ;-) (This happens five times
throughout your patch, BTW.)

>      [AAC_CODER_FAST] = {
>          search_for_quantizers_fast,
> -        encode_window_bands_info,
> +        codebook_trellis_rate,
>          quantize_and_encode_band,
>          ff_aac_encode_tns_info,
>          ff_aac_encode_ltp_info,

Without understanding the code: Is this change related or even desired?

Moritz