[FFmpeg-devel] [PATCHv2] af_hdcd: Don't warn if converting from AV_SAMPLE_FMT_S16P

Burt P. pburt0 at gmail.com
Mon Aug 8 19:29:49 EEST 2016

applied, as dbd7a84c814161926e5f298eae1f5ea17082f814, with an
additional check that AVFilterLink->type is AVMEDIA_TYPE_AUDIO before
calling av_get_sample_fmt_name() on AVFilterLink->format. Thanks for
pointing that out.

I will look into disabling auto-conversions when the filter is used
and removing the invasive scan.

On Mon, Aug 8, 2016 at 5:16 AM, Nicolas George <george at nsup.org> wrote:
> Le primidi 21 thermidor, an CCXXIV, Burt P. a écrit :
>> Are you now talking about plans of the future or this specific case?
> Both.
>> As it is, automatic conversion is very helpful, for example from
>> WavePack, which uses s16p.
> Apparently, not all of them are to your liking. FFmpeg can not guess which
> ones. You could try to teach it, but it may prove tricky. The best solution
> is to let the user choose, and that is exactly what disabling the automatic
> conversion does.
> Note that it does not disable conversions, only automatic ones. It also does
> not disable format negotiation. The only thing that changes is that the user
> has to choose where the conversion happens.
>> This filter is only looking at the AVFilterLinks between filters, not
>> at the filters themselves.
> And with lavfi's design, this is not allowed. As is, the filter is scanning
> links that it does not even know are audio, let alone are in any way
> connected to it.
>> This scan and warn behavior was added to address a real issue.
> That is more or less the Transportation Security Administration's motto, and
> we all know what a catastrophe that is. Good intentions are not enough to
> make a solution correct, and this solution is not correct at all.
>> Consider these example cases:
> None of them involve anything remotely complicated.
> Regards,
> --
>   Nicolas George
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


More information about the ffmpeg-devel mailing list