[FFmpeg-devel] [PATCH 3/4] lavc: Add a flag in AVPacket to discard packet after decoding. Discard frames after decoding based on the flag.

Sasi Inguva isasi at google.com
Tue Aug 16 04:42:04 EEST 2016


skip_samples shouldn't be negative. But it's not enforced because it is an
int field. Changed the condition to equality. Added an assert where
skip_samples is populated.

On Sun, Aug 14, 2016 at 5:40 AM, Clément Bœsch <u at pkh.me> wrote:

> On Tue, Aug 09, 2016 at 06:48:21PM -0700, Sasi Inguva wrote:
> [...]
> > +        if ((frame->flags & AV_FRAME_FLAG_DISCARD) &&
> avctx->internal->skip_samples <= 0) {
>
> skip_samples can be negative?
>
> if so, that looks like a behaviour change we want documented
>
> if not, you probably want to check against 0 equality and add an assert.
>
> --
> Clément B.
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>


More information about the ffmpeg-devel mailing list