[FFmpeg-devel] [PATCH] ffmpeg/qsv: fix QSV-accelerated transcode performance drop issue

Michael Niedermayer michael at niedermayer.cc
Tue Aug 16 18:12:49 EEST 2016


On Tue, Aug 16, 2016 at 11:45:52AM +0300, Ivan Uskov wrote:
> 
> Hello Jun,
> 
> Thursday, August 11, 2016, 10:59:51 AM, you wrote:
> 
> > From cafa70e97ce48b65e2a4a99782f6ce3557fef755 Mon Sep 17 00:00:00 2001
> > From: Jun Zhao <mypopydev at gmail.com>
> > Date: Thu, 11 Aug 2016 15:34:01 +0800
> > Subject: [PATCH] ffmpeg/qsv: fix QSV-accelerated transcode performance drop
> >  issue.
> 
> > the merge commit 1b04ea1 "avconv: create simple filtergraphs earlier"
> > will init the filtergraphs earlier, then init the QSV transcode can't
> > suppose the nb_filters's value, else lead to the QSV transcode performance
> > drop.
> 
> > Signed-off-by: Jun Zhao <mypopydev at gmail.com>
> > ---
> >  ffmpeg_qsv.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> > diff --git a/ffmpeg_qsv.c b/ffmpeg_qsv.c
> > index 95a2351..acc54dd 100644
> > --- a/ffmpeg_qsv.c
> > +++ b/ffmpeg_qsv.c
> > @@ -210,8 +210,7 @@ int qsv_transcode_init(OutputStream *ost)
> >  
> >      /* check if the decoder supports QSV and the output only goes to this stream */
> >      ist = input_streams[ost->source_index];
> -    if (ist->nb_filters || ist->hwaccel_id != HWACCEL_QSV ||
> -        !ist->dec || !ist->dec->pix_fmts)
> +    if (ist->hwaccel_id != HWACCEL_QSV || !ist->dec || !ist->dec->pix_fmts)
> >          return 0;
> >      for (pix_fmt = ist->dec->pix_fmts; *pix_fmt != AV_PIX_FMT_NONE; pix_fmt++)
> >          if (*pix_fmt == AV_PIX_FMT_QSV)
> Thank, makes sense.
> LGTM.

applied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160816/13bbea78/attachment.sig>


More information about the ffmpeg-devel mailing list