[FFmpeg-devel] [PATCH 2/3] af_hdcd: check return value of av_frame_copy_props()

Burt P pburt0 at gmail.com
Tue Aug 23 02:01:20 EEST 2016


Anton Khirnov:
"[av_frame_copy_props()] potentially contains memory allocation,
so the return value needs to be checked."

Signed-off-by: Burt P <pburt0 at gmail.com>
---
 libavfilter/af_hdcd.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/libavfilter/af_hdcd.c b/libavfilter/af_hdcd.c
index 1bcd279..2324dc3 100644
--- a/libavfilter/af_hdcd.c
+++ b/libavfilter/af_hdcd.c
@@ -1530,14 +1530,18 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *in)
     AVFrame *out;
     const int16_t *in_data;
     int32_t *out_data;
-    int n, c;
+    int n, c, result;
 
     out = ff_get_audio_buffer(outlink, in->nb_samples);
     if (!out) {
         av_frame_free(&in);
         return AVERROR(ENOMEM);
     }
-    av_frame_copy_props(out, in);
+    result = av_frame_copy_props(out, in);
+    if (result) {
+        av_frame_free(&in);
+        return result;
+    }
     out->format = outlink->format;
 
     in_data  = (int16_t*)in->data[0];
-- 
2.7.4



More information about the ffmpeg-devel mailing list