[FFmpeg-devel] [PATCH 05/21] libavformat/movenc: mov_write_ftyp_tag: write the major brand a compatible brand

[Carl Eugen Hoyos]

Hi!

2016-08-24 16:53 GMT+02:00 Erkki Seppälä <erkki.seppala.ext at nokia.com>:
>
> On 08/23/2016 10:00 PM, Carl Eugen Hoyos wrote:
>>>
>>> +    if (mov->mode == MODE_MP4 && mov->major_brand)
>>> +        ffio_wfourcc(pb, mov->major_brand); /* write major brand as a
>>> compatible brand */
>>
>> How can I reproduce the issue this is trying to fix?
>
> The issue we were fixing was that in the presence of custom major brand (the
> option "brand" is set) the custom major brand did not end up in the
> compatible brands.

Thanks for explaining!
(I couldn't find the option yesterday.)

> (In retrospect, this would have been a great commit
> message..)

Yes;-)

> An alternative for our use case would be adding the option
> "compatible_brands" for setting custom compatible brands from the client
> code.

The advantage is that I believe users have asked for this.

No more comments from me, Carl Eugen