[FFmpeg-devel] [PATCH] Fix audiomatch complie warning

Michael Niedermayer michael at niedermayer.cc
Thu Aug 25 03:08:57 EEST 2016


On Wed, Aug 24, 2016 at 10:20:11PM +0800, Steven Liu wrote:
> Making sure bestpos is initialized to zero to prevent gcc from kvetching.
> It's harmless (although it's not obvious that it's harmless)
> from code inspection:
> tests/audiomatch.c: In function ‘main’:
> tests/audiomatch.c:40: warning: ‘bestpos’ may be used uninitialized in this
> function
> 
> Thanks to Moritz Barsnick for first bringing this to the attention.
> 
> Signed-off-by: LiuQi <liuqi at gosun.com>
> ---
>  tests/audiomatch.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/audiomatch.c b/tests/audiomatch.c
> index 9752f68..9fb511f 100644
> --- a/tests/audiomatch.c
> +++ b/tests/audiomatch.c
> @@ -37,11 +37,11 @@ int main(int argc, char **argv){
>      FILE *f[2];
>      int i, pos;
>      int siglen, datlen;
> -    int bestpos;
> +    int bestpos = 0;

> -    double bestc=0;
> -    double sigamp= 0;
> +    double bestc = 0;
> +    double sigamp = 0;
>      int16_t *signal, *data;
> -    int maxshift= 16384;
> +    int maxshift = 16384;

unrelated changes
(these belong in a seperate patch)

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160825/c1e6f284/attachment.sig>


More information about the ffmpeg-devel mailing list