[FFmpeg-devel] [PATCH] tests/fate:Add FATE for hls_flags append option

Michael Niedermayer michael at niedermayer.cc
Thu Aug 25 18:02:59 EEST 2016


On Thu, Aug 25, 2016 at 08:01:02PM +0800, Steven Liu wrote:
> 2016-08-25 6:16 GMT+08:00 Michael Niedermayer <michael at niedermayer.cc>:
> 
> > On Wed, Aug 24, 2016 at 09:40:55PM +0800, Steven Liu wrote:
> > > 2016-08-24 19:14 GMT+08:00 Steven Liu <lingjiujianke at gmail.com>:
> > >
> > > >
> > > >
> > > > 2016-08-24 18:57 GMT+08:00 Michael Niedermayer <michael at niedermayer.cc
> > >:
> > > >
> > > >> On Wed, Aug 24, 2016 at 06:28:08PM +0800, Steven Liu wrote:
> > > >> > 2016-08-24 18:23 GMT+08:00 Michael Niedermayer
> > <michael at niedermayer.cc
> > > >> >:
> > > >> >
> > > >> > > On Wed, Aug 24, 2016 at 03:04:59PM +0800, Steven Liu wrote:
> > > >> > > > On OSX test:
> > > >> > > > localhost:ffmpeg liuqi$ uname -a
> > > >> > > > Darwin localhost 15.5.0 Darwin Kernel Version 15.5.0: Tue Apr 19
> > > >> 18:36:36
> > > >> > > > PDT 2016; root:xnu-3248.50.21~8/RELEASE_X86_64 x86_64
> > > >> > > > localhost:ffmpeg liuqi$ make fate-filter-hls-append
> > > >> > > > HOSTCC tests/base64.o
> > > >> > > > HOSTLD tests/base64
> > > >> > > > HOSTCC tests/tiny_psnr.o
> > > >> > > > HOSTLD tests/tiny_psnr
> > > >> > > > HOSTCC tests/tiny_ssim.o
> > > >> > > > HOSTLD tests/tiny_ssim
> > > >> > > > HOSTCC tests/audiomatch.o
> > > >> > > > tests/audiomatch.c:102:12: warning: using floating point
> > absolute
> > > >> value
> > > >> > > > function 'fabs' when argument is of integer type
> > [-Wabsolute-value]
> > > >> > > >         if(fabs(c) > sigamp * 0.94)
> > > >> > > >            ^
> > > >> > > > tests/audiomatch.c:102:12: note: use function 'llabs' instead
> > > >> > > >         if(fabs(c) > sigamp * 0.94)
> > > >> > > >            ^~~~
> > > >> > > >            llabs
> > > >> > > > tests/audiomatch.c:103:40: warning: using floating point
> > absolute
> > > >> value
> > > >> > > > function 'fabs' when argument is of integer type
> > [-Wabsolute-value]
> > > >> > > >             maxshift = FFMIN(maxshift, fabs(pos)+32);
> > > >> > > >                                        ^
> > > >> > > > tests/audiomatch.c:103:40: note: use function 'abs' instead
> > > >> > > >             maxshift = FFMIN(maxshift, fabs(pos)+32);
> > > >> > > >                                        ^~~~
> > > >> > > >                                        abs
> > > >> > > > tests/audiomatch.c:25:28: note: expanded from macro 'FFMIN'
> > > >> > > > #define FFMIN(a,b) ((a) > (b) ? (b) : (a))
> > > >> > > >                            ^
> > > >> > > > tests/audiomatch.c:103:40: warning: using floating point
> > absolute
> > > >> value
> > > >> > > > function 'fabs' when argument is of integer type
> > [-Wabsolute-value]
> > > >> > > >             maxshift = FFMIN(maxshift, fabs(pos)+32);
> > > >> > > >                                        ^
> > > >> > > > tests/audiomatch.c:103:40: note: use function 'abs' instead
> > > >> > > >             maxshift = FFMIN(maxshift, fabs(pos)+32);
> > > >> > > >                                        ^~~~
> > > >> > > >                                        abs
> > > >> > > > tests/audiomatch.c:25:34: note: expanded from macro 'FFMIN'
> > > >> > > > #define FFMIN(a,b) ((a) > (b) ? (b) : (a))
> > > >> > > >                                  ^
> > > >> > > > tests/audiomatch.c:104:12: warning: using floating point
> > absolute
> > > >> value
> > > >> > > > function 'fabs' when argument is of integer type
> > [-Wabsolute-value]
> > > >> > > >         if(fabs(c)>fabs(bestc)){
> > > >> > > >            ^
> > > >> > > > tests/audiomatch.c:104:12: note: use function 'llabs' instead
> > > >> > > >         if(fabs(c)>fabs(bestc)){
> > > >> > > >            ^~~~
> > > >> > > >            llabs
> > > >> > > > 4 warnings generated.
> > > >> > > > HOSTLD tests/audiomatch
> > > >> > > > GEN     tests/data/hls-list-append.m3u8
> > > >> > > > TEST    filter-hls-append
> > > >> > > >
> > > >> > > >
> > > >> > > >
> > > >> > > >
> > > >> > > > On Linux Test:
> > > >> > > > [root at localhost ffmpeg]# make fate-filter-hls-append
> > > >> > > > HOSTCC tests/base64.o
> > > >> > > > HOSTLD tests/base64
> > > >> > > > HOSTCC tests/tiny_psnr.o
> > > >> > > > HOSTLD tests/tiny_psnr
> > > >> > > > HOSTCC tests/tiny_ssim.o
> > > >> > > > HOSTLD tests/tiny_ssim
> > > >> > > > HOSTCC tests/audiomatch.o
> > > >> > > > tests/audiomatch.c: 在函数‘main’中:
> > > >> > > > tests/audiomatch.c:40: 警告:此函数中的‘bestpos’在使用前可能未初始化
> > > >> > > > HOSTLD tests/audiomatch
> > > >> > > > GEN     tests/data/hls-list-append.m3u8
> > > >> > > > TEST    filter-hls-append
> > > >> > > > [root at localhost ffmpeg]# uname -a
> > > >> > > > Linux localhost.localdomain 2.6.32-431.el6.x86_64 #1 SMP Fri
> > Nov 22
> > > >> > > > 03:15:09 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux
> > > >> > >
> > > >> > > fails with mingw
> > > >> > > ../configure  --cc='ccache i686-w64-mingw32-gcc'  --samples=...
> > > >> --arch=x86
> > > >> > > --target-os=mingw32 --cross-prefix=i686-w64-mingw32- --enable-gpl
> > > >> > > --pkg-config=./pig-config --target_exec=wine
> > > >> > >
> > > >> > > ...
> > > >> > > +0,     873216,     873216,     1152,     2304, 0x823b822c
> > > >> > > +0,     874368,     874368,     1152,     2304, 0xa1658479
> > > >> > > +0,     875520,     875520,     1152,     2304, 0xdbe58ff7
> > > >> > > +0,     876672,     876672,     1152,     2304, 0x725175e2
> > > >> > > +0,     877824,     877824,     1152,     2304, 0xb2ae7741
> > > >> > > +0,     878976,     878976,     1152,     2304, 0x4de169e4
> > > >> > > +0,     880128,     880128,     1152,     2304, 0x3cb18530
> > > >> > > +0,     881280,     881280,     1152,     2304, 0x48b95d6c
> > > >> > > +0,     882432,     882432,     1152,     2304, 0xcff707ef
> > > >> > > Test filter-hls-append failed. Look at
> > tests/data/fate/filter-hls-app
> > > >> end.err
> > > >> > > for details.
> > > >> > > make: *** [fate-filter-hls-append] Error 1
> > > >> > > make: *** Waiting for unfinished jobs....
> > > >> > >
> > > >> > ...... ok, let me find a Windows Environment to fix it.
> > > >>
> > > >> the failure was on a ubuntu with wine, i dont know if it fails on a
> > > >> native windows
> > > >> ok, i see, i'll test this patch on windows
> > > >
> > > >
> > > Hi Michael,
> > >
> > >       I have check the patch on Windows System, It's OK,
> >
> > well, it must work with mingw and wine on unix too
> >
> > [...]
> > --
> > Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> >
> > Freedom in capitalist society always remains about the same as it was in
> > ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
> >
> >
> >
> Hi Michael,
> 
> It's this ENV same as your wine+mingw?

it looks similar

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160825/85cabbfb/attachment.sig>


More information about the ffmpeg-devel mailing list