[FFmpeg-devel] [PATCH 3/3] vf_colorspace: Allow overriding input color properties

[Clément Bœsch]

On Fri, Aug 26, 2016 at 08:58:57PM +0200, Clément Bœsch wrote:
> On Fri, Aug 26, 2016 at 02:43:35PM -0400, Vittorio Giovara wrote:
> > On Fri, Aug 26, 2016 at 3:52 AM, Paul B Mahol <onemda at gmail.com> wrote:
> > > On 8/26/16, Vittorio Giovara <vittorio.giovara at gmail.com> wrote:
> > >> The filter needs input frames with color properties filled out by
> > >> the decoder. Since this is not always possible, add input options to
> > >> the filter so that user may override color space, color primaries,
> > >> transfer characteristics, and color range.
> > >>
> > >> Signed-off-by: Vittorio Giovara <vittorio.giovara at gmail.com>
> > >> ---
> > >> Please keep me in CC.
> > >> Vittorio
> > >>
> > >>  libavfilter/vf_colorspace.c | 28 ++++++++++++++++++++++++----
> > >>  1 file changed, 24 insertions(+), 4 deletions(-)
> > >
> > > Generally, new options should be added after old ones.
> > 
> > I added closer to the original options because they share exactly the
> > same input values, and seemed to logically belong there: in case an
> > option is added to or removed from the group, the developer can
> > immediately notice that the change is going to affect both options.
> 
> The problem with not adding them at the end is that it breaks user
> interface: order matters when your specifying successive options without

you're*

sorry for any triggering it caused.

-- 
Clément B.